Your patch has been added to the PostgreSQL unapplied patches list at:

        http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Zoltan Boszormenyi wrote:
> Hi
> 
> Bruce Momjian ?rta:
> > Zoltan Boszormenyi wrote:
> >   
> >> Hi!
> >>
> >> Thanks.
> >>
> >> However, in the meantime I made some changes
> >> so the IDENTITY column only advances its sequence
> >> if it fails its CHECK constraints or UNIQUE indexes.
> >> I still have some work with expression indexes.
> >> Should I post an incremental patch against this version
> >> or a full patch when it's ready?
> >>     
> >
> > Full patch.
> >   
> 
> Then here it is. Now it's really finished, I promise. :-)
> Changes:
> 
> - unique index checks are done in two steps
>   to avoid inflating the sequence if a unique index check
>   is failed that doesn't reference the IDENTITY column
> - to minimize runtime impact of checking whether
>   an index references the IDENTITY column and skipping it
>   in the first step in ExecInsertIndexTuples(), I introduced
>   a new attribute in the pg_index catalog. I had to place it
>   in the middle of the fixed size attributes because I had
>   mysterious crashes otherwise. This means the attributes
>   are renumbered. This attribute is determined during
>   CREATE INDEX and recomputed for all indexes defined
>   on the table during ALTER TABLE SET/DROP IDENTITY.
> - as a consequence, IDENTITY/GENERATED can now
>   have CHECK constraints, this limit was removed.
> - modified testcase for the above changes
> - reworded documentation
> 
> Please, review.
> 
> Best regards,
> Zolt?n B?sz?rm?nyi
> 

[ application/x-tar is not supported, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to [EMAIL PROTECTED] so that your
>        message can get through to the mailing list cleanly

-- 
  Bruce Momjian  <[EMAIL PROTECTED]>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
       subscribe-nomail command to [EMAIL PROTECTED] so that your
       message can get through to the mailing list cleanly

Reply via email to