> +                     defstring = defGetString(defel);
> +                     if (pg_strcasecmp(defstring, "True") == 0)
> +                             d->acceptAll = true;
> +                     else if (pg_strcasecmp(defstring, "False") == 0)
> +                             d->acceptAll = false;
> +                     else
> +                             ereport(ERROR,
> +                                     
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> +                                      errmsg("invalid value for AcceptAll 
> parameter: \"%s\"",
> +                                                     defstring)));

This bit should be replaced with defGetBoolean.  Otherwise it looks
reasonably sane.

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

                http://www.postgresql.org/about/donate

Reply via email to