Bruce Momjian wrote:

> In testing I found the regression tests were failing because of a divide
> by zero error (fixed), and a missing case where the column delimiter has
> to be ":".  In fact I now see all your line continuation cases using ":"
> rather than "!".  It actually looks better --- "!" was too close to "|"
> to be easily recognized.  (Did you update your patch to use ":".  I
> didn't see "!" in your patch.)

I think we should use a different separator when there is an actual
newline in the data.  Currently we have a : there, so using a : here is
probably not the best idea.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches

Reply via email to