Re: [Pharo-dev] Release Mode

[Ben Coman]

Marcus Denker wrote: On 28 Mar 2014, at 16:17, Sven Van Caekenberghe <s...@stfx.eu> wrote: On 28 Mar 2014, at 16:00, Marcus Denker <marcus.den...@inria.fr> wrote: On 28 Mar 2014, at 15:52, Sean P. DeNigris <s...@clipperadams.com> wrote: While I was on holiday, it seems my dear friends have gone feature crazy... almost as bad as me in the run up to the 2.0 release, ha ha. As cool as they are, are: - changing the look of Nautilus buttons - evaluate arbitrary expressions in Spotlight - etc, etc showstopping bugs?! This beta time is reserved specifically for finding the bugs that may inevitably be introduced with these enhancements. We really may be creating a mess, as end users find them in our "stable" release instead. Yes, it was wrong… maybe we should revert. Marcus Yes, maybe ;-) I don't like the red (ish) / orange rectangle around dirty text areas (instead of the orange thing in the corner)  - Where did that come from ? Did we discuss about that ? I thought that the refactoring of the themes was just a refactoring (not changing anything). <Screen Shot 2014-03-28 at 16.14.56.png> PS: I marked the 'evaluate arbitrary expressions in Spotlight' not as a bug, but an enhancement, with would be nice priority, but indeed for 3.0 - but I certainly cannot blame Markus either - and BTW, there was a discussion about it, people tested it and nobody said no - and it is a perfectly safe change ;-) PS2: I do have a bit of a problem with people being so vocally against changes, unless they are fixing the hard bugs themselves instead. If we all do nothing, the release won't get better, right ? I know that I will not integrate anything anymore…. I wait till people send mails to the list to ask to integrate something, and at least 3 people vote positive. Marcus My fault.  The submitted slice had some legitimate Theme bug fixes but mixed in was flattening of the Theme hierarchy by moving Pharo3Theme to subclass from UITheme rather than UIThemeWatery.   That part was "cleanup" rather than "bug fix" and I had some concerns which I failed to voice.   To revert that part I've uploaded SLICE-Issue-13114-Broken-PharoTheme-BenComan.3.   Hilaire, Could you review this to check it looks okay.  For overall effect this slice should be reviewed against build 30802. http://files.pharo.org/image/30/30802.zip -ben