I agree with you Ben, problem was the fix I did for broekn watery theme
also interlaced with the clean up in the hierachy.
My suggestion is to mark the unwished visual changes in the Pharo3 theme
as bug for Pharo 4, then proceed.

Hilaire

Le 28/03/2014 19:40, Ben Coman a écrit :
> My fault.  The submitted slice had some legitimate Theme bug fixes but
> mixed in was flattening of the Theme hierarchy by moving Pharo3Theme to
> subclass from UITheme rather than UIThemeWatery.   That part was
> "cleanup" rather than "bug fix" and I had some concerns which I failed
> to voice.   To revert that part I've uploaded
> SLICE-Issue-13114-Broken-PharoTheme-BenComan.3.   Hilaire, Could you
> review this to check it looks okay.  For overall effect this slice
> should be reviewed against build 30802.
> http://files.pharo.org/image/30/30802.zip

-- 
Dr. Geo http://drgeo.eu


Reply via email to