2015-09-08 11:03 GMT+02:00 Martin Dias <[email protected]>: > On Sat, Sep 5, 2015 at 1:10 PM, Nicolai Hess <[email protected]> wrote: > > The same for the ]lang[ tag (see issue 15750) > > Ok. But I still don't know how to add a url to a method's source code > or comment from the UI. > > I mean, people with a non-English keyboard can produce source code > with ]lang[, but how can I produce a ]style[ ? >
Hi Martin, In squeak, you can open a "choose style" dialog (select some text and use shortcut cmd+6). This lets you choose a text color or text links. For example, this is working in the class comment editor too, you can open the comment for class Morph, select a word like "Rectangle" and put a link to that class definition. This style attributes are first only a part of the Text instance, but saving or file out the class definition will include this style attributes with the ]style[ tag. Writing the style code text is not supported in pharo anymore. Changing the style (color and text links) with cmd+6 does not work in Rubrics text components anymore. It is working with the old PluggableTextMorph (but only color attributes - no links). Reading Text with style attributes is still working in Pharo (only color and emphasis, no text links). For example, put this "styled" text in a Workspace and inspect it: 'Red Gree Blue! ]style[(3 1 4 1 4)f1cred;b,f1b,f1cgreen;b,f1b,f1cblue;b!' readStream nextChunkText > > Martín > > > > > 2015-09-05 12:06 GMT+02:00 Martin Dias <[email protected]>: > >> > >> Hi all > >> > >> On Sat, Sep 5, 2015 at 3:44 AM, Ben Coman <[email protected]> wrote: > >> > On Sat, Sep 5, 2015 at 4:43 AM, Eliot Miranda < > [email protected]> > >> > wrote: > >> >> > >> >> On Sep 4, 2015, at 1:33 PM, stepharo <[email protected]> wrote: > >> >> > >> >> Nobody defines urls in method comment anymore. > >> >> > >> >> I do. Several places in the Cog JIT contain irks to specification > >> >> documents. I don't care how its implemented (providing it's > preserved > >> >> in > >> >> text, or maybe have the pretty-printer scan comments for http://. > But > >> >> it is > >> >> sad that we can't have hyperlinks in text. > >> >> > >> >> Look I know the implementation stinks, but it can be fixed. But if > the > >> >> functionality is lost the system is weakened. Instead of asking what > >> >> you > >> >> can get rid if why not ask what you can reimplement or enhance more > >> >> elegantly. > >> > > >> > Its a reasonable strategy to start the discussion at the extreme end > >> > and work back from there :) But if its being used we should think > >> > harder about it. What alternatives/workarounds are there? > >> > > >> > First just to clarify, the aim is to remove Text from the image for > >> > the boot-strap? > >> > >> Yes :) I heard that we want to do cut the dependency to Text-Core, so > >> I browsed how to do it. > >> > >> Ben, there is an explanation about ]style[ in the class comment of > >> RemoteString. > >> > >> Eliot, I didn't thought that somebody was using Text. In fact, I don't > >> know how to do it in Pharo... how do you do? > >> I found that ChangeRecord>>fileIn uses #newTextChunk to parse, but I > >> just tested filing-in the attached .st file and it doesn't work. I > >> guess the new CodeImporter replaced the ChangeRecord implementation, > >> and it raises an error when ]style[. > >> > >> Martín > >> > >> > >> > > >> > 1. Save the text internally as a string in the stream format and > >> > up-convert to Text only when its being displayed? But I guess these > >> > styles aren't restricted to just occurring in comments and maybe cause > >> > problem for compilation ?? > >> > > >> > 2. As a stepping stone, introduce a TextPlaceholder class within > >> > minimal interface required by compilation which simply strips out all > >> > styles when Text is missing from the Image. When Text is present it > >> > #becomes back to it. Maybe risks loosing styles editing is done on > >> > the raw-stream-format. Maybe any editor would show the raw ]style[ > >> > and the compiler asks for #source which strips styles out. > >> > > >> > 3. Introduce Pillar and convert across. What are the requirements? > >> > a. URLs > >> > b. Class/method links > >> > c. Would you expect that Pillar can only appear in comments? Or > >> > in-line with code? > >> > d. Colouring? > >> > ...? > >> > > >> > btw, I haven't come across this before. Can someone point me to some > >> > url & styled code where I can have a look at it > >> > > >> > cheers -ben > >> > > >> >> Christ you're even using minis paced fonts. It's like the dark > >> >> ages in there ;-) > >> >> > >> >> In addition would prefer to have an explicit syntax as in Pillar or > >> >> html to > >> >> represent > >> >> an hyperlink. We could have > >> >> *Class>>#method* when pillar is not loaded and else a nicer > >> >> representation. > >> >> ctrl-click on a class should jump on it already and we could map it > to > >> >> *Class>>#method* > >> >> > >> >> In class comments we should use pillar and get a real text renderer. > >> >> > >> >> > >> >> Hi Martin, > >> >> > >> >> On Fri, Sep 4, 2015 at 8:13 AM, Martin Dias <[email protected]> > >> >> wrote: > >> >>> > >> >>> Hi all, > >> >>> > >> >>> The source code of a method could be a Text, with TextAttributes. In > >> >>> such > >> >>> case, it will be written down to a stream with a "]style[" suffix. > >> >>> Through a > >> >>> special parsing, the system can reconstruct the original Text. I > think > >> >>> the > >> >>> use of Text in source code or class comments is discouraged, but I > >> >>> understand we kept support for some backward compatibility. Now, may > >> >>> be it's > >> >>> time to remove this feature. > >> >>> > >> >>> With Pablo, we looked for uses of ]style[ in the .sources and > .changes > >> >>> files of a new Pharo 5.0, and there are no real uses. It appears in > >> >>> some > >> >>> comments only, as examples. > >> >>> > >> >>> We tried to find past discussions about this feature, because we're > >> >>> sure > >> >>> there were, but we couldn't. > >> >>> > >> >>> So, the questions is: > >> >>> > >> >>> Can we remove support for text in source code or class comments > in > >> >>> Pharo 5.0? > >> >> > >> >> > >> >> IIUC, ]style[ also supports things like embedding URL links and > method > >> >> references in class comments. So I would request that it /not/ be > >> >> removed. > >> >> It is very useful to put clickable links in class comments. > >> >> > >> >>> > >> >>> > >> >>> I think I can propose a slice. > >> >>> > >> >>> Regards, > >> >>> Martín > >> >>> PS: I was trying to cut dependencies of Text-Core with > System-Changes > >> >>> and > >> >>> System-Changes. > >> >> > >> >> > >> >> > >> >> > >> >> -- > >> >> _,,,^..^,,,_ > >> >> best, Eliot > >> >> > >> >> > >> > > > > > >
