I checked the code and it looks nice

Now I found

split: regexString
        self assert: regexString size > 0 description: 'Cannot split on empty  
regex'.
        ^regexString asRegex split: self

and assert: expects a block.
for the test

        testSplit
self assert: (eg split: 'the') size = 4. self assert: (eg split: 't\w 
+e') size = 5. self assert: (eg split: 'hello') size = 1.
        it would be nice to have also an assert showing the result and not  
just its size


then I have a question what splitBy: returns?
does it return a collection that is the same kind of the receiver?
Why do you hard code an OrderedCollection in splitBySubCollection:  
aSplitter.
  self species would do it too?
Syef


On Apr 5, 2009, at 9:51 AM, Oscar Nierstrasz wrote:

>
> Hi Folks,
>
> What's the status of split and join?
>
> http://bugs.squeak.org/view.php?id=4874
>
> I need them for a project and since they are not there yet, I have
> gone back to RubyShards.
>
> http://squeaksource.com/RubyShards/
>
> Keith, do you think this can be integrated into Pharo already, or does
> it need some work still?
>
> (I think our implementation is not particularly efficient, but it
> should be serviceable.)
>
> Cheers,
> - on
>
>
> _______________________________________________
> Pharo-project mailing list
> [email protected]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>


_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to