[ 
https://issues.apache.org/jira/browse/PIG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580379#action_12580379
 ] 

Pi Song commented on PIG-94:
----------------------------

Very good work to review.

Here are my suggestions:-
- In the parser, EXECCOMMAND doesn't seem to accept backtick escape characters. 
Do plan to have it or just say backticks aren't allowed?
- Agree with Alan to have a timeout mechanism. You already have got the 
outputBytes variable in PigExecutableManager. Possibly just use it to monitor 
the movement.
- The error handling logic by just printing out on work load nodes will not be 
visible to Pig user.
- This following line in HadoopExecutableManager will not work on Windows:-
{noformat}
FileUtil.chmod(executable.toString(), "a+x");
{noformat}


> Pig Streaming functional spec proposal
> --------------------------------------
>
>                 Key: PIG-94
>                 URL: https://issues.apache.org/jira/browse/PIG-94
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Olga Natkovich
>            Assignee: Arun C Murthy
>         Attachments: patch.txt, PIG-94_1_1_20080304.patch, 
> PIG-94_1_20080303.patch, PIG-94_2_0_20080317.patch, PigStreamingTestPlan.htm
>
>
> This issue is for discussion about Pig streaming functional spec.
> http://wiki.apache.org/pig/PigStreamingFunctionalSpec

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to