[
https://issues.apache.org/jira/browse/PIG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580970#action_12580970
]
Alan Gates commented on PIG-94:
-------------------------------
Commens on patch 2_0_20080317
Looks like there's quite a few leftover printlns in here for debugging. It's
probably easiest to search through the patch file and find all of the places.
I don't understand why the executableManager in StreamSpec is passed in as an
ExecutableManager then stored as a string (~line 40) and then later
instantiated. Is this because it's stored on the front end and instantiated on
the backend?
In StreamingCommand.java, you are parsing the arguments to the streaming
command. Is this something you could have the parser do for you at parse time
and package it in a way that StreamingCommand could use them? We want to avoid
manual parsing whenever possible.
It would be nice to see some unit tests added for streaming. That doesn't have
to be done in this patch.
> Pig Streaming functional spec proposal
> --------------------------------------
>
> Key: PIG-94
> URL: https://issues.apache.org/jira/browse/PIG-94
> Project: Pig
> Issue Type: New Feature
> Reporter: Olga Natkovich
> Assignee: Arun C Murthy
> Attachments: patch.txt, PIG-94_1_1_20080304.patch,
> PIG-94_1_20080303.patch, PIG-94_2_0_20080317.patch, PigStreamingTestPlan.htm
>
>
> This issue is for discussion about Pig streaming functional spec.
> http://wiki.apache.org/pig/PigStreamingFunctionalSpec
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
