[
https://issues.apache.org/jira/browse/PIG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580973#action_12580973
]
Olga Natkovich commented on PIG-94:
-----------------------------------
Arun, sorry I did not have time to review the whole things. But here is
feedback on what I managed to review
(1) There are some System.err.println statements. They need to be converted to
log statements.
(2) Pig script can contain multiple output statements which means multiple
output files. I see that get/setJobOutputFile is a new API in PigContext. Does
the code manages this correctly?
(3) In StreamSpec, you are using log.fatal. I think in the rest of the code we
have been using log.error to indicate fatal errors and log.warn to indicate
warning.
(4) For new files/classes that you added, it would be nice to have a comment
header to explain what that class does and where it is used.
> Pig Streaming functional spec proposal
> --------------------------------------
>
> Key: PIG-94
> URL: https://issues.apache.org/jira/browse/PIG-94
> Project: Pig
> Issue Type: New Feature
> Reporter: Olga Natkovich
> Assignee: Arun C Murthy
> Attachments: patch.txt, PIG-94_1_1_20080304.patch,
> PIG-94_1_20080303.patch, PIG-94_2_0_20080317.patch, PigStreamingTestPlan.htm
>
>
> This issue is for discussion about Pig streaming functional spec.
> http://wiki.apache.org/pig/PigStreamingFunctionalSpec
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
