Hi Shawn, could you just confirm that the webrev holds all the needed info? It's showing an error message at the bottom of it where it couldn't diff the feed icon I think. I just wanted to be certain that was the last change in your wad.
General comments: I didn't see any new test cases. Can we introduce some that will generate an atom feed in the depot (if I've followed this code so far) and retrieve it and (ideally) parse to ensure it's correctness, or would this not fit will within our current testutils suite? In feed.py: Could you either start with a note explaining what d, f in the function argument for set_title mean (I'm pretty sure they're doc and feed, but I didn't figure that out until after reading further in the code) or just change them to be fuller names as you did in add_transaction? Thanks, Brock Shawn Walker wrote: > The following webrev includes proposed fixes for the following bugs: > > 1324 RSS / Atom feeds of repository updates > > webrev: > http://cr.opensolaris.org/~swalker/pkg-1324/ > > Change summary: > * Added a bytes_to_str method to make it easy to get a human-readable > string representing a number of bytes in the largest IEEE Std > 1212-1991 unit possible. > * Changed face.py's page header output to include special alternate > link so that live bookmarks work for RSS/Atom feeds in browsers that > recognize it. > * Changed server index page to include link to RSS/Atom feed. > * Changed server index page to show last update to repository. > * Added new feed module to generate RSS/Atom content. > * Added two new operations to repository: feed and info. > * New info operation provides a summary of a given pkg fmri with the > same output as that of the client. > * Added new feed icon from > http://developer.mozilla.org/en/docs/RSS:Getting_Started:Syndicating. > Usage terms can be found at http://feedicons.com/. > > Thanks to Stephen for the initial wad which I based these changes on. > Most of the work is his. > > Cheers, > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
