Shawn,
Very nice feature. Please consider these comments.
feed.py, line 25:
"generating supporting" in comment.
feed.py, line 33:
Wouldn't the publisher be a later package assembler?
feed.py:
I don't see a method for customizing the values for feed_authority and
feed_author_*. This is essential for repositories that are not serving
up OpenSolaris content.
feed.py, various lines that use cherrypy.url():
What happens when the pkg.depotd server is behind a front-end reverse
proxy web server? Will the web server rewrite the Atom feed to replace
the absolute URLs generated by cherrypy.url()?
feed.py, line 125:
Would it be worth it to try to distinguish between a new package being
added to the catalog vs. an update to a package that was already in the
catalog? As I understand the code now, both of these will show up as an
add operation.
misc.py, line 318:
Isn't the IEEE standard for this 1541? (see:
http://en.wikipedia.org/wiki/IEEE_1541)
src/web/Makefile:
A similar update is needed in the setup.py file at about line 157 in the
variable web_files.
face.py, line 147:
What do you think about make the fmri in the index output a link to the
"info" URI? I realize that this isn't really part of this feature, but
that would seem to be quite nice.
Thanks.
Tom
Shawn Walker wrote:
The following webrev includes proposed fixes for the following bugs:
1324 RSS / Atom feeds of repository updates
webrev:
http://cr.opensolaris.org/~swalker/pkg-1324/
Change summary:
* Added a bytes_to_str method to make it easy to get a human-readable
string representing a number of bytes in the largest IEEE Std
1212-1991 unit possible.
* Changed face.py's page header output to include special alternate
link so that live bookmarks work for RSS/Atom feeds in browsers that
recognize it.
* Changed server index page to include link to RSS/Atom feed.
* Changed server index page to show last update to repository.
* Added new feed module to generate RSS/Atom content.
* Added two new operations to repository: feed and info.
* New info operation provides a summary of a given pkg fmri with the
same output as that of the client.
* Added new feed icon from
http://developer.mozilla.org/en/docs/RSS:Getting_Started:Syndicating.
Usage terms can be found at http://feedicons.com/.
Thanks to Stephen for the initial wad which I based these changes on.
Most of the work is his.
Cheers,
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
