2008/7/13 Brock Pytlik <[EMAIL PROTECTED]>: > Hi Shawn, could you just confirm that the webrev holds all the needed info? > It's showing an error message at the bottom of it where it couldn't diff the > feed icon I think. I just wanted to be certain that was the last change in > your wad.
It is complete. > General comments: > I didn't see any new test cases. Can we introduce some that will generate an > atom feed in the depot (if I've followed this code so far) and retrieve it > and (ideally) parse to ensure it's correctness, or would this not fit will > within our current testutils suite? It doesn't seem to fit within our current testsuite. I would like to add test cases, but I thought I could do that as part of bug: 2300 depot output tests needed My main problem with trying to build validation in is that most of the tools for validation are online. I'm hesitant to include any automatic tests that depend on external resources. In fact, that's my problem with validating depot output in general. I can tell you that I validated it myself using validator.w3.org. > In feed.py: > Could you either start with a note explaining what d, f in the function > argument for set_title mean (I'm pretty sure they're doc and feed, but I > didn't figure that out until after reading further in the code) or just > change them to be fuller names as you did in add_transaction? Will do. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
