2008/7/14 Tom Mueller <[EMAIL PROTECTED]>: > feed.py, line 25: > "generating supporting" in comment.
Fixed. > feed.py, line 33: > Wouldn't the publisher be a later package assembler? Not sure, you'd have to ask Stephen. > feed.py: > I don't see a method for customizing the values for feed_authority and > feed_author_*. This is essential for repositories that are not serving up > OpenSolaris content. I agree, but that sort of falls under bug 2239. I could add that to this wad, though I'm not certain yet how I'll implement it. > feed.py, various lines that use cherrypy.url(): > What happens when the pkg.depotd server is behind a front-end reverse proxy > web server? Will the web server rewrite the Atom feed to replace the > absolute URLs generated by cherrypy.url()? I don't believe it will rewrite the URLs. As I understand it, I need a full, absolute URL to the feed: http://tools.ietf.org/html/rfc4287#section-4.2.6 Uncertain what to do with this. > feed.py, line 125: > Would it be worth it to try to distinguish between a new package being added > to the catalog vs. an update to a package that was already in the catalog? Unfortunately, modules/updatelog.py only provides history for adding packages. > misc.py, line 318: > Isn't the IEEE standard for this 1541? (see: > http://en.wikipedia.org/wiki/IEEE_1541) Hrm. The materials I was using referenced 1212-1991. However, it would seem that 1541-2002 is more appropriate as it is more applicable. 1212-1991 only defined some of this information. Changed. > src/web/Makefile: > A similar update is needed in the setup.py file at about line 157 in the > variable web_files. Fixed. > face.py, line 147: > What do you think about make the fmri in the index output a link to the > "info" URI? I realize that this isn't really part of this feature, but that > would seem to be quite nice. Hrm. Well, it is a bit of feature creep. But I've added info and manifest links. I've also cleaned up the index page quite a bit such that FMRIs are listed in lexical order, etc. New webrev: http://cr.opensolaris.org/~swalker/pkg-1324-2/ -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
