Danek Duvall wrote: > On Mon, Jul 14, 2008 at 02:23:48PM -0700, Danek Duvall wrote: > >> After sitting down for a group code review on Friday, I've made some more >> changes, mostly quite minor. > > If anyone has comments (or wants more time), please respond by 1pm Pacific > today.
Interesting. I just received this email a few minutes ago. Here are my comments anyway: http://cr.opensolaris.org/~dduvall/pkg-newlist3-4/src/modules/catalog.py.wdiff.html ========== 204 + (where names in quotes are strings, names in angle brackets are 205 + objects, and the rest of the syntax is Pythonic. Missing closing parentheses. No other comments. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
