On Mon 21 Jul 2008 at 03:49PM, [EMAIL PROTECTED] wrote:
> > The webrev for proposed changes for the progress is available at:
> > http://cr.opensolaris.org/~migi/ips_progress_changes/
>
> The changes you've made to filelist.py aren't quite right.
>
> The final_path argument that you're passing to download_start_file() is
> actually a destination in the client's content cache directory.
>
> It may not be possible to determine the file name since in some cases,
> multiple different files have the same content.
>
> The file's name is contained in action.path, but you're looking at the
> content hash of the file you're downloading. Notice that it's possible
> for us to have multiple actions associated with a particular piece of
> content, so you could have multiple action.path, each naming a different
> file, for one file you've downloaded from the server.
>
> I would find another way to do this, or exclude the file name.
I noticed the per-file tracking here, as well, and I'm not
convinced that this level of detail makes sense for the GUI unless
you're just trying to persuade the user that we're "doing stuff" and
"working hard".
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
