Dan Price wrote: > On Tue 22 Jul 2008 at 11:37AM, Michal Pryc wrote: >> [EMAIL PROTECTED] wrote: >>>> The webrev for proposed changes for the progress is available at: >>>> http://cr.opensolaris.org/~migi/ips_progress_changes/ >>> The changes you've made to filelist.py aren't quite right. >>> >>> The final_path argument that you're passing to download_start_file() is >>> actually a destination in the client's content cache directory. >>> >>> It may not be possible to determine the file name since in some cases, >>> multiple different files have the same content. >>> >>> The file's name is contained in action.path, but you're looking at the >>> content hash of the file you're downloading. Notice that it's possible >>> for us to have multiple actions associated with a particular piece of >>> content, so you could have multiple action.path, each naming a different >>> file, for one file you've downloaded from the server. >>> >>> I would find another way to do this, or exclude the file name. >> Since IPS is using cache then the final_path is the actual file being >> downloaded. >> Later on this file is being copied to the final destination. Am I wrong? >> >> So you might be right that showing this cache file is useless for >> people, but let's say for debug information it could be important data. > > Progress tracking is about *progress* towards a goal and not about > debugging. It should not aspire to be a general purpose mechanism for > emitting "got here" messages, etc.
Hello Dan, I agree with you. Anyway the single file information is the requirement made during design of the GUI (before writing single line of the code), so we simply need that: http://xdesign.sfbay.sun.com/projects/solaris/subprojects/package_mngt/UI_specs/ui_spec_phase2/html-mockup/05_downloading_dialog.htm As I already wrote in the response for this thread, having this doesn't costs us a lot, since the client will decide to use this progress or not. > We're looking at having a debug framework but that's going to be > a little ways down the road. Great to hear. I think it should be also consumed by GUI, for those who are not using terminal :-) best Michal _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
