Danek Duvall wrote: > On Tue, Jul 22, 2008 at 10:55:45AM +0100, Michal Pryc wrote: > >> Stephen Hahn wrote: >>> Interesting. What would you want the new chunk size to be, typically? >>> How would you adjust it? >> The progress which we currently have is moving once each file is being >> downloaded. If the file is heavy ~2Mb and the connection is slow, users >> might think that the application is simply frozen e.g.lines 223,249: >> http://cr.opensolaris.org/~migi/ips_progress_changes/src/modules/client/filelist.py.html > > Then shouldn't we dismiss the idea of using a chunk size entirely? It > doesn't seem useful, since even downloading a single byte might hang until > there's a timeout. > > The underlying read method in the tarfile can be overridden. We could > easily (I think) call select/poll in there, reading from the network when > there's data available, and off a control pipe to tell us when to stop. A > quick test program shows the mechanisms work just fine. > Danek, Canceling the operation is one thing and nice smooth progress is another one.
The chunk is more important for the progress information, so the user will be able to see that something is being downloaded. If you think that this should be done by overriding the tarfile as well then it's fine for me. Another seprarate thing is canceling download operation. Checking if the chunk was downloaded and if the user canceled operation was idea of having something. Ideally would be to have some mechanism of canceling at any time and if this can be done as you've described then it would solve many problems. Do you have the test program that are you talking about, so I can see how exactly this should work? all the best Michal _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
