[EMAIL PROTECTED] wrote: >> The webrev for proposed changes for the progress is available at: >> http://cr.opensolaris.org/~migi/ips_progress_changes/ > > The changes you've made to filelist.py aren't quite right. > > The final_path argument that you're passing to download_start_file() is > actually a destination in the client's content cache directory. > > It may not be possible to determine the file name since in some cases, > multiple different files have the same content. > > The file's name is contained in action.path, but you're looking at the > content hash of the file you're downloading. Notice that it's possible > for us to have multiple actions associated with a particular piece of > content, so you could have multiple action.path, each naming a different > file, for one file you've downloaded from the server. > > I would find another way to do this, or exclude the file name.
Since IPS is using cache then the final_path is the actual file being downloaded. Later on this file is being copied to the final destination. Am I wrong? So you might be right that showing this cache file is useless for people, but let's say for debug information it could be important data. I agree that we should have information about file from action.path, but I didn't found the simple way of obtaining such information from the current implementation. One way could be getting such information before line 223: http://cr.opensolaris.org/~migi/ips_progress_changes/src/modules/client/filelist.py.html using some object checking and then retrieving attributes from the: self.fhash[hashval] As this we will have information from: inst_path = self.fhash[hashval][0].attrs.get("path") but I think this might be not the best approach, since this is list of hashes so I am not sure when the self.fhash[hashval] might have more then 1 object in it and what we should do in such case. As well I am not sure if all the objects will have "path" attribute in this place? From the GUI stand point of view we really want to have information about files being downloaded and now I thing we should have both the actual file being downloaded aka final_path and also where this file will be installed on the image aka inst_path. -- best Michal _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
