I'm sending out a completely new review request for this wad as I have changed it significantly since the last webrev I sent out. The old versions are still available for comparison.
The following webrev includes proposed fixes for the following bugs: 1324 RSS / Atom feeds of repository updates webrev: http://cr.opensolaris.org/~swalker/pkg-1324-4/ webrev: http://cr.opensolaris.org/~swalker/pkg-1324/ Change summary: * Added a bytes_to_str method to make it easy to get a human-readable string representing a number of bytes in the largest IEEE Std 1212-1991 unit possible. * Changed face.py's page header output to include special alternate link so that live bookmarks work for RSS/Atom feeds in browsers that recognize it. * Changed server index page to include link to RSS/Atom feed. * Changed server index page to show last update to repository. * Added new feed module to generate RSS/Atom content. * Added two new operations to repository: feed and info. * New info operation provides a summary of a given pkg fmri with the same output as that of the client. * Added new feed icon from http://developer.mozilla.org/en/docs/RSS:Getting_Started:Syndicating. Usage terms can be found at http://feedicons.com/. ========== Changes from last webrev (that I can remember): * Added new repository attributes: feed.icon, feed.logo, feed.authority (not to be confused with pkg authority -- read rfc 4151). * Added new depot command line option --proxy-base to specify the base url to use when generating redirects and links (e.g. pkg.opensolaris.org/contrib). This should resolve all outstanding issues with reverse proxy setups. * Fixed many pylint warnings/errors. * Added generic interface module initialization to Repository.__init__ needed by server/feed to clear its cache on startup and set feed.id. * Changed to use new repositoryconfig attribute system for feed settings (makes it possible to "personalize" the depot for third party sites). * Fixed Atom feed ID to be unique by using a UUID. * Fixed RSS entry ids to be properly unique by using a tag uri. * Fixed Author / Email information to be added conditionally based upon the information provided in the configuration. * Fixed a bug in repository.py rename_0 that was using pkg.server.catalog to attempt to catch CatalogException, RenameException -- they only exist in modules/catalog.py, not modules/server/catalog.py. * Added pkg/proxy_base to pkg-server.xml (smf manifest). * Updated man page for depot to reflect new --proxy-base option. Thanks to Stephen for the initial wad which I based these changes on. Most of the feed generation / updatelog work is his. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
