Brock Pytlik wrote: > Sorry this took awhile Shawn, my machine froze last night while I was > working on this, and I didn't get back to it till now. > > Shawn Walker wrote: >> Shawn Walker wrote: >> >>> I'm sending out a completely new review request for this wad as I >>> have changed it significantly since the last webrev I sent out. The >>> old versions are still available for comparison. >>> >>> The following webrev includes proposed fixes for the following bugs: >>> >>> 1324 RSS / Atom feeds of repository updates >>> >>> webrev: >>> http://cr.opensolaris.org/~swalker/pkg-1324-4/ >>> >> >> To be clear, this is the *current* webrev -- all others are original >> or previous ones. >> >> > The --proxy-base argument, is that something that could/should be gotten > from cfg_cache instead of the command line?
No, it's intentionally setup as an argument both so that I can expose it via SMF easily through our existing mechanism and because it has a very large impact on the depot's operation. I want it to be very visible. > misc.py.sdiff.html: > line 320: > I thought we had decided on XB rather than XiB. For consistency, we > should probably agree as a project. I have no desire to have that > particular discussion in detail again, so I'll leave it up to someone > (other than me) to make a decision. No decision was made as far as I know; one comment I received indicated that generally whoever made the change gets to pick. But I am not dead set on either way. We only use the size units at all in two other places in our code. However, in the interest of consistency I've changed this despite my inclinations towards a documented standard instead of tradition. Long-term I feel that we should adopt the new standard in the interest of forward-thinking (e.g. imperial vs. metric and the US has been left behind). > updatelog.py.sdiff.html > lines 427 - 430: > would it be better/faster to just create the dictionary with those three > entries immediately? Probably doesn't make much of a difference. Agreed. > That's all the feedback, from what I can tell it looks ,fine, but this > definitely isn't my area of expertise. Nonetheless, the feedback was appreciated. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
