Sorry this took awhile Shawn, my machine froze last night while I was working on this, and I didn't get back to it till now.
Shawn Walker wrote: > Shawn Walker wrote: > >> I'm sending out a completely new review request for this wad as I have >> changed it significantly since the last webrev I sent out. The old >> versions are still available for comparison. >> >> The following webrev includes proposed fixes for the following bugs: >> >> 1324 RSS / Atom feeds of repository updates >> >> webrev: >> http://cr.opensolaris.org/~swalker/pkg-1324-4/ >> > > To be clear, this is the *current* webrev -- all others are original or > previous ones. > > The --proxy-base argument, is that something that could/should be gotten from cfg_cache instead of the command line? Tiny, tiny nits. misc.py.sdiff.html: line 320: I thought we had decided on XB rather than XiB. For consistency, we should probably agree as a project. I have no desire to have that particular discussion in detail again, so I'll leave it up to someone (other than me) to make a decision. updatelog.py.sdiff.html lines 427 - 430: would it be better/faster to just create the dictionary with those three entries immediately? Probably doesn't make much of a difference. That's all the feedback, from what I can tell it looks ,fine, but this definitely isn't my area of expertise. Best of luck, Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
