Brock, I've commited some of the changes that you have made as an fix for: 3193 IPS GUI throws exceptions when installing/upgrading a package in the revision 510.
http://cr.opensolaris.org/~bpytlik/ips-3039-v1/src/gui/modules/installupdate.py.wdiff.html I think only this change will be needed ?: 45 -import pkg.indexer as indexer 45 +import pkg.client.indexer as indexer The line 42 of remove.py uses import for indexer, but I see that I forgot to remove this import. It should be removed as it will break things (pkg.indexer will be pkg.client.indexer now): 42 import pkg.indexer as indexer best Michal Brock Pytlik wrote: > Micahel and John (and anyone else out there with experience with the GUI > side of the code), > > Could you please take a look at the changes to installupdate.py? I'd > like to make sure I haven't made any obvious mistakes. > > Also, could you provide some guidance on how you test the GUI? I'd like > to make sure I do the same kinds of tests you're performing whenever I > need to touch the things in gui/modules. It's not code I'm familiar with > so I'd definitely appreciate any suggestions on how to at least ensure > I've touched the major code paths. > > Thanks, > Brock > > > Brock Pytlik wrote: >> Of course, the correct webrev is at: >> http://cr.opensolaris.org/~bpytlik/ips-3039-v1/ >> >> Sorry bout that, >> Brock >> >> Brock Pytlik wrote: >> >>> Webrev: >>> file:///export/home/bpytlik/IPS/recommit.bug-3039-v1/webrev/index.html >>> >>> bugs: >>> 3039: Install and Image-update should check index consistency with >>> installed packages >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3039 >>> >>> 3059: Search should check index consistency with installed packags >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3059 >>> >>> 3192: indexer should timeout when versions in existing index are >>> permanently mismatched >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3192 >>> >>> 3194: The rebuild of the index at the end of imageplan must force the >>> image to reload its package state >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3194 >>> >>> This change seems to have no negative effect on the time performance of >>> search, and may actually make things slightly faster for reasons I don't >>> understand. The central part of this change is that during install, >>> uninstall, image-update, and search, what the image thinks is installed >>> is compared to what the indexer thought was installed, if those don't >>> match, an error is reported (during search) or the indexes are repaired >>> (during the other actions). It also cleans up a few other bugs I ran >>> into while testing the code that needed to be fixed in order to fully >>> test the changes. >>> >>> Thanks for taking a look, >>> Brock >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>> >>> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
