General comment: Can you check installupdate.py line 619 and see if this should be changed to a TransportException?
retrieve.py: line 266-267: I think these are covered by lines 284-285. One of the pairs should be removed Brock Dan Price wrote: > Folks, > > I have the following fixes for you to review: > > 3777 PKG_TIMEOUT_MAX is a placebo setting > 3778 We can be more informative and accurate when timeouts happen > 3779 Some KeyboardInterrupt exception handling can be cleaner > > http://cr.opensolaris.org/~dp/pkg-timeout > > This provides some substantial improvements to experience for > end users when timeouts are encountered. Here is what it looks > like when two of your mirrors are timing you out: > > $ PKG_TIMEOUT_MAX=10 pkg install SUNWfirefox > > DOWNLOAD PKGS FILES XFER (MB) > > SUNWfirefox 0/41 831/8287 1.89/112.19 > > > pkg: An unexpected error happened while preparing for install: > > pkg: Maximum number of timeouts exceeded during download. Details follow: > > 1: Transfer from 'http://localhost:22223' timed out. (happened 5 times) > > 2: Transfer from 'http://localhost:22222' timed out. (happened 5 times) > > This code also copes with bad content exceptions, etc, and gives > a nice tidy printout. > > We've also talked about adding information to the progress tracker > when timeouts happen. That is not in this wad, I ran out of time. > > -dp > > -- > Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - > blogs.sun.com/dp > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
