On Wed 08 Oct 2008 at 10:57AM, Danek Duvall wrote:
> On Wed, Oct 08, 2008 at 01:50:33AM -0700, Dan Price wrote:
>
> > http://cr.opensolaris.org/~dp/pkg-timeout
>
> client.py:
>
> - line 1958: given that you're now catching a more generic exception,
> does the text here still hold in all cases?
I think it is sort-of right, since we're going to retry on all of the
exceptions we get, but the logic is sort of in the wrong place. I will
work on it.
> misc.py:
>
> - line 450: if exceptions isn't a sequence ... ?
I took out the constructor param.
> - line 463: I think it's legitimate to want to print out the object
> before it has any exceptions in it -- for debugging or whatnot. You
> probably just want to return a different string in this case.
Fixed.
> retrieve.py:
>
> - line 266: we already had a KeyboardInterrupt handler ...
Fixed. tx.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
