> > - lines 1954 - 1968: I think the ordering of these exception handlers > > is backwards. Since InvalidContentException is a subclass of > > TransportException, the first TransportException handler is going to > > catch _all_ of the TransportExceptions, including InvalidContent. I > > don't think that's what you want. At a minimum, I'd put > > InvalidContent before Transport. However, since the printout for > > the TransportException handler specifically mentions timeouts, > > perhaps what you really wanted to catch here was a > > TransferTimedOutException? I'm not sure. > > Great catch. Thanks. Do you think that it's ever possible in > the current code for an InvalidContentException to wind up at > the top level? As best I can tell, InvalidContent can never > propagate to the top level in the current code (as I've altered it). > It's caught in all cases and either silently fixed, or retried. Do you > agree?
I agree. I got confused, thinking that a TransportError was making it to the top, not a TransportFailures. With this in mind, the InvalidContextException is defunct and should probably be removed. Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
