On Wed, Oct 08, 2008 at 10:36:18AM -0700, Brock Pytlik wrote: > Brad Hall wrote: > >On Wed, Oct 08, 2008 at 10:30:10AM -0500, Shawn Walker wrote: > > > >>Dan Price wrote: > >> > >>>Folks, > >>> > >>>I have the following fixes for you to review: > >>> > >>>3777 PKG_TIMEOUT_MAX is a placebo setting > >>>3778 We can be more informative and accurate when timeouts happen > >>>3779 Some KeyboardInterrupt exception handling can be cleaner > >>> > >>>http://cr.opensolaris.org/~dp/pkg-timeout > >>> > >>General concerns: > >>How are we going to deal with localisation of messages that are > >>generated within our apis instead of from client.py? I'm not asking you > >>to address that in this patch, but a general idea would be nice. > >> > >>client.py: > >> line 1959: The str() around 'e' isn't needed given the '%s' construct? > >> > >>misc.py: > >> line 424: what about having global_settings in pkg.client instead? > >>it would seem a better home than "misc" for something central to the > >>client. > >> > >>[snip] > >> > > > >Looks great. I don't have any additional comments -- though +1 to the > >comment > >about moving it from misc :) > > > >-Brad > >_______________________________________________ > >pkg-discuss mailing list > >[email protected] > >http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > > > > Are these settings for the CLI only? If so, then putting them into > pkg.client makes sense. If not, for example if we'd like the GUI to have > the same behavior regarding timeouts and retries as the CLI, then > pkg.client is not the place for it to go.
I'd vote for moving the exceptions into src/modules/exceptions.py and the global stuff into src/modules/globals.py, etc. I don't feel that strongly about it; maybe we can do it later once misc.py grows. -Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
