Only comment I have is I think I'd be happier if check_cancellation was an argument to pkgPlan.download, rather than being part of the constructor, as long as this doesn't require significant replumbing.
I'd also like K, or someone else familiar with the transport code to take a look before it goes into the gate. Brock Michal Pryc wrote: > Hi, > > Bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=3717 > > > Webrev: > http://cr.opensolaris.org/~migi/08_10_2008_cancel_during_download_3717/ > > I would really be happy if you could review this ASAP. > > I have tested those bits and the cancelation works fine. If cancel was > requested the cancel exception is thrown after the file being downloaded > will finish. > > best > Michal > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
