[EMAIL PROTECTED] wrote: >> I'd also like K, or someone else familiar with the transport code to >> take a look before it goes into the gate. >> > > >>> Webrev: >>> http://cr.opensolaris.org/~migi/08_10_2008_cancel_during_download_3717/ >>> > > This doesn't look quite right to me. > > Who catches the CanceledException? Is there any cleanup required? > It will get caught by the client (cli or packagemanager). I'm not sure if there will be cleanup required or not. I thought you would have more insight than I do into what the consequences of essentially exiting directly to client code from this deep might be.
Brock > At a minimum, this shouldn't be done in _make_opener(). This function > returns a function to get the data of the downloaded file. If we know a > cancellation has been requested, it doesn't make sense to extract the > file, start assigning openers to actions, and then possibly throw an > exception. > > I would put this at the beginning of _extract_file(), before the call to > tar_stream.extract_to(). > > Thanks, > > -j > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
