[EMAIL PROTECTED] wrote: >> New webrev (hopefully you will be fine with that and I can commit this >> Today): >> http://cr.opensolaris.org/~migi/09_10_2008_cancel_during_download_3717/ > > In general, this looks fine. Thanks for making these changes. > > I have a stylistic nit for line 272 in filelist.py. In the case where > an exception is raised and no arguments are passed, it's sufficient to > simply write the type of exception without adding parenthesis. The code > is correct either way. Shawn or Danek may have additional thoughts > about what style is desireable here, but it did occur to me that you > could omit the () here and the code would work just fine. >
Hi, Thanks for comments. I was actually following other points for example line 254: http://src.opensolaris.org/source/xref/pkg/gate/src/modules/client/imageplan.py?r=567 Brock, any comment which way should I go? best Michal _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
