[EMAIL PROTECTED] wrote: >> I'd also like K, or someone else familiar with the transport code to >> take a look before it goes into the gate. > >>> Webrev: >>> http://cr.opensolaris.org/~migi/08_10_2008_cancel_during_download_3717/ > > This doesn't look quite right to me. > > Who catches the CanceledException? Is there any cleanup required? > > At a minimum, this shouldn't be done in _make_opener(). This function > returns a function to get the data of the downloaded file. If we know a > cancellation has been requested, it doesn't make sense to extract the > file, start assigning openers to actions, and then possibly throw an > exception. > > I would put this at the beginning of _extract_file(), before the call to > tar_stream.extract_to(). Thanks for comments, I will make those changes. Also I don't think we should clean up the files as user might resume the download after cancellation, so all the files will be in the download folder. Later on we could pop up dialog telling if user want's to clean up the download cache, or maybe when the disk space is low...
Thoughts? Michal > Thanks, > > -j > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
