On Fri, Oct 17, 2008 at 09:09:00PM -0700, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-4053-v1/
api_errors.py:
- line 101: I'm confused by this -- it doesn't add anything, unless
self.unfound_fmris is ever not an iterable (like, say, None). List
comprehensions that iterate over an empty list are themselves empty
lists, so the previous incarnation of this code shouldn't have been
doing anything to res with an empty self.unfound_fmris except create an
empty list.
It looks like in both cases that the exception is raised, a list, even
if empty, is passed in for unfound and multiple. One case passes None
in for missing, but that could be fixed.
image.py:
- line 2175: Do we really need the if here? Either calling inventory()
raises InventoryException (so catch it and set unfound) or it succeeds,
and you can set missing.
Also, what happens if inventory() raises InventoryException because of
an illegal FMRI. Does the messaging make sense then?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
