On Mon, Oct 20, 2008 at 03:00:33PM -0700, Brock Pytlik wrote:

> http://cr.opensolaris.org/~bpytlik/ips-4053-v2/

api_errors.py:

  - line 104: you're far better off just saying "pattern(s)" than going to
    all this effort to try to get the plural correct.  It works for
    English, but pretty much nothing else.  You might also do a better job
    of wrapping the text (say, to 70 characters).

image.py:

  - line 2111: Is this an assertion?

    I'm also a bit confused as to how you end up with illegal fmris caught
    in two different ways.  Is one from inventory and the other from the
    optional dependency application?  Perhaps then they should be in
    different try blocks?

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to