[EMAIL PROTECTED] wrote: >> Updated webrev: >> http://cr.opensolaris.org/~bpytlik/ips-4053-v3 >> > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > > api_error.py: > > - line 102: I try to avoid giving feedback on variable names, since > it's irrelevant to the correctness of the code. However, > unfound_fmris made me cringe. Might I suggest unmatched_fmris, or > lost_fmris? > > Otherwise, this looks fine to me. > > -j > Sure, I like lost_fmris. I'll make the change here and put back unless others have more comments.
Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
