[EMAIL PROTECTED] wrote: >> Updated webrev: >> http://cr.opensolaris.org/~bpytlik/ips-4053-v3 >> > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > > api_error.py: > > - line 102: I try to avoid giving feedback on variable names, since > it's irrelevant to the correctness of the code. However, > unfound_fmris made me cringe. Might I suggest unmatched_fmris, or > lost_fmris? > > Otherwise, this looks fine to me. > > -j >
Actually, I'm not going to make this change now. It would be an incompatible change and I'm going to try to avoid those as we come into 2008.11 unless they're absolutely necessary. I'll file a bug and get rid of the name here, and in make_(un)install_plan after that. Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
