* Dan Price <[EMAIL PROTECTED]> [2008-10-30 00:49]:
>
> Please take a look at this fix:
>
> 3509 IndexError gathering driver aliases
>
> http://cr.opensolaris.org/~dp/pkg-3509/
>
> This attempts to harden the code which processes various device files,
> and in my testing is more resilient to various bits of malformedness
> therein. Comments welcomed.
*. Are the .rstrip() calls wrong, or are you changing to .strip() for
some other reason?
91,
442. It would be nice to use one pattern for opening name_to_major.
Maybe a function?
612. (Typo.) "[ ]" -> "[]"
The loop bodies are all the same, but I can't think of a simple way to
get better reuse here.
Fine otherwise.
- Stephen
--
[EMAIL PROTECTED] http://blogs.sun.com/sch/
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
