On Thu, Oct 30, 2008 at 05:50:16PM -0700, Dan Price wrote:
> http://cr.opensolaris.org/~dp/pkg-3509-2/
line 125: we could break here, no?
line 457: odd to have this here. Why not "if line.startswith("#"):
continue" after line 453? And didn't we find that .startswith() was really
slow? I'd turn this into a list comprehension after removing that test,
too:
result_fields = [
field.strip('"')
for field in fields
]
line 622: "[]"
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss