On Thu 30 Oct 2008 at 02:37PM, Stephen Hahn wrote: > * Dan Price <[EMAIL PROTECTED]> [2008-10-30 00:49]: > > > > Please take a look at this fix: > > > > 3509 IndexError gathering driver aliases > > > > http://cr.opensolaris.org/~dp/pkg-3509/ > > > > This attempts to harden the code which processes various device files, > > and in my testing is more resilient to various bits of malformedness > > therein. Comments welcomed. > > *. Are the .rstrip() calls wrong, or are you changing to .strip() for > some other reason? > > 91, > 442. It would be nice to use one pattern for opening name_to_major. > Maybe a function? > > 612. (Typo.) "[ ]" -> "[]" > > The loop bodies are all the same, but I can't think of a simple way to > get better reuse here. > > Fine otherwise.
So it seems like it would be better to have a single parser for the "binding file" family of things. Here's a more substantial rework. This fixes a number of issues with the old parser and makes the new one a lot more like the kernel's read_binding_file() parser. This should make us more tolerant towards oddball entries. I also filed and fixed a bug in which we don't do verification of clone nodes, and we easily can. http://cr.opensolaris.org/~dp/pkg-3509-2/ I'll wait for a review from Danek, but multiple eyes appreciated. -dp -- Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
