Hi Dan, I took a look at this and couldn't find anything objectionable. One thing that occurred to me is that it might be worthwhile to replace the IOError exception handlers with the more generic EnvironmentError exception. (Both IOError and OSError are a subclass of EnvironmentError). However, it looks like there isn't any code that would actually raise an OSError, so you're pretty safe.
Sorry I don't have more useful feedback. -j On Fri, Oct 31, 2008 at 03:42:21PM -0700, Dan Price wrote: > On Thu 30 Oct 2008 at 05:50PM, Dan Price wrote: > > > > So it seems like it would be better to have a single parser for > > the "binding file" family of things. > > > > Here's a more substantial rework. This fixes a number of issues > > with the old parser and makes the new one a lot more like the kernel's > > read_binding_file() parser. This should make us more tolerant towards > > oddball entries. > > > > I also filed and fixed a bug in which we don't do verification > > of clone nodes, and we easily can. > > > > http://cr.opensolaris.org/~dp/pkg-3509-2/ > > > > I'll wait for a review from Danek, but multiple eyes appreciated. > > If anyone has cycles, I need review for this. Danek, hoping you will > look at it. > > -dp > > -- > Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - > blogs.sun.com/dp > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
