Beyond Daneks comments, I just have nit-picks and a question.
solaris.py:
line 878: should there be spaces either side of the "=" ?
line 881: should the command line options be in alphabetical order
(j: is wrong). I realize you didn't change/add this.
Does this mean that there should no longer be any
.../distro-import/[i386,sparc]/<package_name> files
and all the architectural specific stuff that was in those
files can be places in .../distro-import/common/<package_name>
with lines starting with either $i386_ONLY or $sparc_ONLY ?
If so, that's really nice.
Danek Duvall wrote:
> On Mon, Dec 08, 2008 at 02:21:49PM -0800, Bart Smaalders wrote:
>
>
>> http://cr.opensolaris.org/~barts/3246/
>>
>
> Is there a reason you chose to define $sparc_ONLY as " " rather than ""
> when doing an x86 import (and vice versa)?
>
> solaris.py:
>
> - you've added a bunch of spaces to the end of lines; please delete.
>
> - line 892: space after comma
>
> - line 1010: "defined"
>
> - line 1016: does this turn the entire line into a comment (at least when
> read through read_full_line())?
>
> - line 1019: You'll hit this if you run off the end of the for-loop
> without breaking out of it, which means that you never actually use the
> while loop. I think something's not right here.
>
> - line 1165: should this slurp in the reest of the line?
>
> Danek
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
