On Tue, Dec 09, 2008 at 12:49:39PM -0800, Bart Smaalders wrote: >> - line 1019: You'll hit this if you run off the end of the for-loop >> without breaking out of it, which means that you never actually use >> the while loop. I think something's not right here. > > Yup; adding comment clipping disabled nested macros... I've changed this > a bunch, and made it more robust in the face of different macros, etc.
Looks better. I might still myself loop only over the string, extract "$(...)" constructs, and test for inclusion in the macro dictionary, but either way works. Line 1047: "while True" is the idiom we've been using. Is the "isspace" thing necessary? Could you test against "" instead? Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
