Danek Duvall wrote: > On Mon, Dec 08, 2008 at 02:21:49PM -0800, Bart Smaalders wrote: > >> http://cr.opensolaris.org/~barts/3246/ > > Is there a reason you chose to define $sparc_ONLY as " " rather than "" > when doing an x86 import (and vice versa)? > > solaris.py: > > - you've added a bunch of spaces to the end of lines; please delete. >
weird; done. > - line 1016: does this turn the entire line into a comment (at least when > read through read_full_line())? yup; I decided that trying to support more granular use was not necessary.... If this is a problem, I can work out a more sophisticated mechanism, but the 99.9% case will be $(arch_ONLY) at the beginning of the line. > > - line 1019: You'll hit this if you run off the end of the for-loop > without breaking out of it, which means that you never actually use the > while loop. I think something's not right here. > Yup; adding comment clipping disabled nested macros... I've changed this a bunch, and made it more robust in the face of different macros, etc. > - line 1165: should this slurp in the reest of the line? > Hmmm... trying to consider desired behavior w/ commented, continued lines. read_token already grabs the rest of the line. Read_full_line also supports macro expansion to comments, but it effectively comments the entire line out. I've also fixed a problem where line numbers are wrong because we read lines w/o incrementing the line count... I've updated the webrev @ http://cr.opensolaris.org/~barts/3246/ - Bart -- Bart Smaalders Solaris Kernel Performance [EMAIL PROTECTED] http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
