Brock,
Thanks for doing this change.
api.py:
line 300:
should there be a call to history?
I am not entirely sure, but maybe it would be worth adding
api.check_be_name(be_name) as a function returning True if this be_name is
available and False if not, then when user will type in the GUI the name we
could check on the fly the name. Of course the exception should stay as it is
now in the plan_update_all function?
The rest looks fine for me.
best
Michal Pryc
----- Original Message -----
From: Tom Mueller <[email protected]>
Date: Wednesday, February 18, 2009 5:35 pm
Subject: Re: [pkg-discuss] Code review for 3718, 2883, 3748 please
To: Brock Pytlik <[email protected]>
Cc: pkg discuss <[email protected]>
> Since this is the first mention of the boot environment in the manual
> page, maybe it would be appropriate to explain the conditions under
> which a boot environment is created and what happens if this argument
> is provided, but no boot environment is going to be created. For
> example, when operating on a user image as a non-root user,
> image-update never creates a new boot environment. I would expect
> this argument to be ignored then, right?
>
> Tom
>
>
> Brock Pytlik wrote:
> >http://cr.opensolaris.org/~bpytlik/ips-3718-v1/
> >
> >Which hopes to fix
> >
> >3718 plan_update_all needs to have an optional argument for the new
> BE name
> >
> >http://defect.opensolaris.org/bz/show_bug.cgi?id=3718
> >
> >2883 image-update should have option to choose new BE name
> >http://defect.opensolaris.org/bz/show_bug.cgi?id=2883
> >
> >3748: beCopy should be called with no arguments, then the clone renamed
> >http://defect.opensolaris.org/bz/show_bug.cgi?id=3748
> >
> >It adds a new optional parameter to the plan_update_all call of the
> API which allows specification of the name the cloned BE is given.
> >
> >Thanks for taking a look,
> >Brock
> >
> >_______________________________________________
> >pkg-discuss mailing list
> >[email protected]
> >http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
