I'm fine with just documenting the failure case and adding the see also as Shawn suggested.
Thanks.
Tom

Brock Pytlik wrote:
Tom Mueller wrote:
Since this is the first mention of the boot environment in the manual page, maybe it would be appropriate to explain the conditions under which a boot environment is created and what happens if this argument is provided, but no boot environment is going to be created. For example, when operating on a user image as a non-root user, image-update never creates a new boot environment. I would expect this argument to be ignored then, right?
Nope, if you specify a BE name and a new BE isn't created, the code will throw an exception and a cli user will receive an error message. This seems to satisfy least surprise since if I provide a new BE name, and the command ran correctly, I would certainly expect there to be a new BE with that name. Lines 190/191 and 370/371 cover this in bootenv.py.

I don't really think the --be-name is the appropriate place to explain what a BE is, how they work, or when they're created, etc. I'm fine with documenting that the command will fail if a be-name is given but none is to be created, but beyond that, I think that's out of scope. If a user chooses to use this feature, then most likely they're either just image-updating their main installed image naively, in which case this should work, or they're working on a user or alternative image, which means they're most likely already sufficiently sophisticated to know what a BE is.

Brock


Tom


Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-3718-v1/

Which hopes to fix

3718 plan_update_all needs to have an optional argument for the new BE name

http://defect.opensolaris.org/bz/show_bug.cgi?id=3718

2883 image-update should have option to choose new BE name
http://defect.opensolaris.org/bz/show_bug.cgi?id=2883

3748: beCopy should be called with no arguments, then the clone renamed
http://defect.opensolaris.org/bz/show_bug.cgi?id=3748

It adds a new optional parameter to the plan_update_all call of the API which allows specification of the name the cloned BE is given.

Thanks for taking a look,
Brock

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss



begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to