Brock Pytlik wrote:
New webrev at:
http://cr.opensolaris.org/~bpytlik/ips-3718-v2/
Shawn, I took several looks at those lines whose formatting you thought
were strange, and I didn't see anything wrong with them. Would you take
a look at this webrev and see if the concerns are still there, and if
so, what's wrong?
Other changes include adding check_be_name as a static method of the API
class and adding more text to the man page.
man/pkg.1.txt:
lines 26-27, 106: can you alphabetise the options?
lines 108-118: i think it would be far more readable to separate the
"with -flag" text by newlines as we did for image-create.
client.py:
lines 477-478: can you alphabetise the options?
client/api_errors.py:
lines 277-278: suggest rewording as "Unable to clone the current boot
environment."
lines 287-292: suggest reformatting, rewording as:
return _("Unable to rename the boot environment currently named "
"%(orig)s to %(dest)s.") % { "orig": self.original_name,
"dest": self.destination_name }
...I think that's the "right" way. Danek would know.
lines 301-302: don't use ' characters to quote key names, always use "
you included the % {} within the _(); it needs to be outside that
there should always be a space after : characters in dicts
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
