Brock Pytlik wrote:
Shawn Walker wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-2670-v2/
Here's the next webrev. It's synced with Shawn's putback, and covers
most of the comments that J and Bart had. One thing that hasn't gone
in yet are the comments that were requested. I plan to do those
tomorrow. It also moves all the files touched to have copyright 2009
on them.
Comments I agreed with and fixed have been removed.
--------------------
src/client.py:
--------------------
line 913: I really think return_actions should be False by default.
I believe most users are going to expect a list of packages as the
result instead of a list of actions -- it's what I plan on doing for
the web interface. Any objections?
I think the web interface should have a button to click, but I have no
objections to it being set to packages by default.
I'd like to stick to -a being the default for another build or two so
that I can make sure that -p is doing what it really should be. I
think what's there right now won't match the users' expectations with
compound queries. I only realized this yesterday, and the fix to get
the right behavior isn't simple.
As a further followup. If we switch to -p being the default, then to
search olders servers will require the user to specify -a. Given that
it'll probably be a while before the servers we don't control switch
over, I think this is another reason for defaulting to -a.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
