Brock Pytlik wrote:
Shawn Walker wrote:
Brock Pytlik wrote:
Shawn Walker wrote:
Brock Pytlik wrote:
[snip]
This should be the rough process:
src/modules/server/api.py
===================
* increment the CURRENT_API_VERSION variable
* Update the search methods in CatalogInterface to use the new
search code, removing ones that no longer apply (such as search_done())
src/web/index.shtml
===================
* increment the CLIENT_API_VERSION variable
src/web/en/base.html
===================
* increment the CLIENT_API_VERSION variable
Strangely, this doesn't seem to actually need to be done.
Odd, nevertheless it should be. The CLIENT_API_VERSION variables
should always match the CURRENT_API_VERSION in modules/server/api.py.
Yeah, it needed to be changed in several places, I made a subset of
changes which worked, but wasn't correct.
Anyway, I've got this working to return list of packages.
I've put a new webrev up for it here
http://cr.opensolaris.org/~bpytlik/ips-2670-v3/
If you could take a look and let me know if the bui/api changes look
right to you, I'd appreciate it. I'll be sending out a fuller webrev
once I Danek and I finish hashing a few things out and I fill in all the
missing comments.
Speaking of which, you need a docstring on
pkg.server.api.CatalogInterface.search() :-)
Otherwise:
src/modules/server/api.py
=========================
line 136: any reason we can't expose case_sensitive, return_actions,
and start_point and num_to_return here so that templates can use these?
src/web/en/search.shtml
=========================
lines 64-76: make sure these tips still apply, you'll also need to
change src/web/en/index.shtml lines 60-72 if you change these.
lines 118, 129: drop the ' colspan="1"'
line 140: s/a different keyword/different keywords/
line 141: s/a more general keyword/more general keywords/
----------
Finally, when search returns a set of results as packages, will it
return the same package more than once?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
