Thanks.  Too much Java (and not the liquid kind) :-)

I'll write up a test case like that. Tom

Shawn Walker wrote:
Tom Mueller (pkg-discuss) wrote:
Please review this fix for issue 7378:
http://cr.opensolaris.org/~tmueller/ips-7378/

Webrev: http://cr.opensolaris.org/~tmueller/ips-7378/

modules/client/bootenv.py:
  line 372: drop the ';'

The only other thought that comes to mind is that we could add an automated test to ensure this doesn't happen again for the BootEnvNull class. Specifically, you could use the inspect module to cycle over the methods in BootEnv in a test case and then verify that the BootEnvNull class had all the same ones.

Cheers,

begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to