I've updated the fix to include a test case to make sure BootEnvNull
includes the public methods from BootEnv.
new webrev: http://cr.opensolaris.org/~tmueller/ips-7378.2/
Thanks.
Tom
Shawn Walker wrote:
Tom Mueller (pkg-discuss) wrote:
Please review this fix for issue 7378:
http://cr.opensolaris.org/~tmueller/ips-7378/
Webrev: http://cr.opensolaris.org/~tmueller/ips-7378/
modules/client/bootenv.py:
line 372: drop the ';'
The only other thought that comes to mind is that we could add an
automated test to ensure this doesn't happen again for the BootEnvNull
class. Specifically, you could use the inspect module to cycle over
the methods in BootEnv in a test case and then verify that the
BootEnvNull class had all the same ones.
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
