Thanks for the quick review.
Shawn Walker wrote:
Tom Mueller (pkg-discuss) wrote:
I've updated the fix to include a test case to make sure BootEnvNull
includes the public methods from BootEnv.
new webrev: http://cr.opensolaris.org/~tmueller/ips-7378.2/
tests/api/t_bootenv.py:
lines 23, 25: insert a newline starting with '#' here to fit the
standard copyright block style
I copied this header from one of the other files in that directory and
every file I've checked has this same format. Can you point to an
example of the new format?
line 41: turn this into a docstring and ensure it wraps at 80
characters
line 46: should wrap at 80 characters
Fixed.
Thanks.
Tom
Cheers,
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
